feat: Update dependencies and project by ArthurKun21 · Pull Request #4 · ArthurKun21/adam

ArthurKun21 · 2026-02-14T15:26:05Z

Following Update Project Dependencies and Gradle Build Configurations #1 going to perform some dependency upgrade and try to resolve any issues accompanying it

gemini-code-assist · 2026-02-14T15:26:44Z

Summary of Changes

Hello @ArthurKun21, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a comprehensive dependency upgrade across the project, updating core libraries like Kotlin, Coroutines, Ktor, and Vert.x to their latest versions. This involved adapting the codebase to new API changes, particularly in asynchronous operations with Vert.x and byte channel handling with Ktor. Additionally, several internal utility classes were refactored for improved maintainability and to remove deprecated dependencies, ensuring compatibility and leveraging new features from the updated ecosystem.

Highlights

Extensive Dependency Upgrades: Major version bumps for Kotlin, Coroutines, Ktor, Vert.x, and various testing and build-related libraries, as reflected in gradle/libs.versions.toml.
Ktor I/O API Migration: Significant refactoring of byte channel read/write operations across StubSocket, ServerReadChannel, ServerWriteChannel, and KtorSocket to align with updated io.ktor.utils.io APIs, including explicit byte array handling and little-endian conversions.
Vert.x Coroutine API Update: Transitioned from await() to coAwait() for suspending functions in Vert.x-related socket implementations, adapting to changes in vertx-kotlin-coroutines.
Logging Library Update: Switched the Kotlin logging library from io.github.microutils to io.github.oshai.
Internal Refinements: Removed Netty dependency from VariableSizeRecordParser, updated temporary file creation in tests, and added deprecation suppressions in AndroidX modules.

Changelog

adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/PortForwardE2ETest.kt
- Removed explicit string-to-integer conversion for port values in assertions.
adam/src/main/kotlin/com/malinskiy/adam/log/AdamLogging.kt
- Updated logging library package imports.
adam/src/main/kotlin/com/malinskiy/adam/transport/vertx/VariableSizeRecordParser.kt
- Refactored buffer handling, removed Netty dependency, and updated argument validation.
adam/src/main/kotlin/com/malinskiy/adam/transport/vertx/VertxSocket.kt
- Migrated Vert.x coroutine suspension calls from await() to coAwait() and updated buffer length retrieval.
adam/src/main/kotlin/com/malinskiy/adam/transport/vertx/VertxSocketFactory.kt
- Migrated Vert.x coroutine deployment calls from await() to coAwait().
adam/src/test/kotlin/com/malinskiy/adam/request/framebuffer/ScreenCaptureRequestTest.kt
- Removed unused Ktor utility import.
adam/src/test/kotlin/com/malinskiy/adam/request/pkg/multi/CreateMultiPackageSessionRequestTest.kt
- Removed deprecated Ktor byte channel imports and related code, and updated temporary file creation.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v1/PullFileRequestTest.kt
- Removed unused Ktor utility import.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v2/PullFileRequestTest.kt
- Removed unused Ktor utility import.
android-junit4/src/main/kotlin/com/malinskiy/adam/junit4/android/rule/AdbRule.kt
- Added @OptIn annotation for UnsafeAdbAccess.
androidx-screencapture/src/main/kotlin/com/malinskiy/adam/junit4/android/screencapture/AdamScreenCaptureProcessor.kt
- Added file-level deprecation suppression.
androidx-screencapture/src/main/kotlin/com/malinskiy/adam/junit4/android/screencapture/AdamScreenCaptureRule.kt
- Added file-level deprecation suppression.
gradle/libs.versions.toml
- Upgraded various project dependencies and updated the Kotlin logging library module.
server/server-stub-junit5/src/main/kotlin/com/malinskiy/adam/server/junit5/AdbServerExtension.kt
- Updated afterEach method signature to remove nullable ExtensionContext.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/AndroidDebugBridgeServer.kt
- Updated Ktor selector manager, adapted socket binding, and changed output channel closing to flushAndClose.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ConsoleReadChannel.kt
- Migrated Ktor UTF8 line reading to generic line reading.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/EmulatorConsoleServer.kt
- Updated Ktor selector manager and changed output channel closing to flushAndClose.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ServerReadChannel.kt
- Refactored byte and integer reading methods, updated channel closing, and adapted byte array writing.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ServerWriteChannel.kt
- Refactored byte and integer writing methods, and adapted byte array writing.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/StubSocket.kt
- Updated Ktor byte channel usage, refactored byte and integer read/write operations, and changed channel closing.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/Session.kt
- Removed unused Ktor utility import.
transport-ktor/src/main/kotlin/com/malinskiy/adam/transport/ktor/KtorSocket.kt
- Refactored byte and integer read/write operations using new Ktor APIs, added flushing, and updated channel closing.
transport-ktor/src/main/kotlin/com/malinskiy/adam/transport/ktor/KtorSocketFactory.kt
- Updated Ktor selector manager instantiation.

Activity

The pull request description indicates this is a follow-up to issue Update Project Dependencies and Gradle Build Configurations #1, aiming to perform dependency upgrades and resolve any accompanying issues.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

ArthurKun21 · 2026-02-14T15:29:05Z

Found a project that uses the latest version of adam, going to try it on my forked version of it

https://github.com/ArthurKun21/adbpad

gemini-code-assist

Code Review

This pull request updates several project dependencies and adapts the codebase to the new APIs. While most of the changes are correct adaptations, I've found a critical issue in the integration tests that will cause a compilation failure due to a type mismatch. Additionally, there are several performance regressions in the Ktor-based transport layer and test stubs due to inefficient use of the new Ktor IO APIs, leading to unnecessary memory allocations. I have provided suggestions on how to fix these performance issues by using ByteBuffer for more efficient, zero-copy operations. The other changes look good.

adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/PortForwardE2ETest.kt

transport-ktor/src/main/kotlin/com/malinskiy/adam/transport/ktor/KtorSocket.kt

server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/StubSocket.kt

server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ServerWriteChannel.kt

server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ServerReadChannel.kt

ArthurKun21 · 2026-02-14T15:59:28Z

Going to reduce the number of integration test to 24, 34 and 35 😭😭😭

ArthurKun21 · 2026-02-14T17:44:20Z

spotless apply problem was due to me not on proper IDE for much easier resolving of errors, I perform spotless Apply but I also rolled back the enforcement of it.

I might soon be able to start this once with proper IDE once this lands due to no more old dependencies

ArthurKun21 · 2026-02-14T17:46:18Z

Explicit APIs are done too. Going to start entertaining the Code review later on.

ArthurKun21 · 2026-02-14T17:47:09Z

oh wait, give priority to dokka

adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/ScreenCaptureRequest.kt

ArthurKun21 · 2026-02-15T03:30:06Z

adam/src/main/kotlin/com/malinskiy/adam/request/misc/ReconnectRequest.kt


-sealed class ReconnectTarget
-object Device : ReconnectTarget()
+public sealed class ReconnectTarget


Probably become data object

ArthurKun21 · 2026-02-15T03:30:28Z

adam/src/main/kotlin/com/malinskiy/adam/request/adbd/AdbdMode.kt

+public sealed class AdbdMode(public val requestString: String)
+public object RootAdbdMode : AdbdMode("root:")
+public object UnrootAdbdMode : AdbdMode("unroot:")
+public object UsbAdbdMode : AdbdMode("usb:")
+public class TcpIpAdbdMode(port: Int) : AdbdMode("tcpip:$port")


Probably change into data object

ArthurKun21 · 2026-02-15T03:35:39Z

adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/model/State.kt

 package com.malinskiy.adam.request.testrunner.model

-sealed class State(val terminal: Boolean)
+public sealed class State(public val terminal: Boolean)


change to data class

*data object

ArthurKun21 · 2026-02-15T03:36:46Z

adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/model/TestStatusAggregator.kt

+public data class TestStatusAggregator(
+    public var statusCode: Status,
+    public val logcatBuilder: StringBuilder = StringBuilder(Const.MAX_PROTOBUF_LOGCAT_LENGTH),
+    public val metrics: MutableMap<String, String> = mutableMapOf(),
 )


Check if we can make it to remove the var, for immutability

ArthurKun21 · 2026-02-15T06:04:42Z

/gemini summary

gemini-code-assist · 2026-02-15T06:09:53Z

Summary of Changes

This pull request undertakes a substantial modernization of the project's core dependencies, updating to the latest stable versions of Kotlin, Coroutines, Ktor, and Vert.x. This necessitated widespread code adjustments to accommodate API changes, particularly in asynchronous I/O and coroutine patterns. Concurrently, the build system received a significant overhaul, introducing new Gradle convention plugins to streamline configuration for Java and Android modules, and to standardize Maven publishing. These changes collectively aim to enhance the project's technical foundation, improve maintainability, and ensure compatibility with the latest ecosystem advancements.

Highlights

Dependency Upgrades: Major version bumps for Kotlin, Coroutines, Ktor, Vert.x, and various testing and build-related libraries, as reflected in gradle/libs.versions.toml.
Ktor I/O API Migration: Significant refactoring of byte channel read/write operations across StubSocket, ServerReadChannel, ServerWriteChannel, and KtorSocket to align with updated io.ktor.utils.io APIs, including explicit byte array handling and little-endian conversions.
Vert.x Coroutine API Update: Transitioned from await() to coAwait() for suspending functions in Vert.x-related socket implementations, adapting to changes in vertx-kotlin-coroutines.
Logging Library Update: Switched the Kotlin logging library from io.github.microutils to com.squareup.logcat.
Gradle Build System Refactoring: Introduced new buildSrc plugins (adam.java, IntegrationTestConfig, MavenPomConfig) for better modularity and consistency in build configurations, including integration test setup and Maven publishing.
API Visibility Enhancement: Many internal classes, functions, and properties across the adam module were explicitly marked public, improving the library's API clarity and usability.
Deployment Script Removal: Old GitHub and Sonatype deployment scripts were removed, indicating a shift in deployment strategy, likely towards the new Maven Publish plugin configuration.
New Documentation File: A comprehensive AGENTS.md file was added, detailing build/test procedures, architecture, key dependencies, code style, and CI setup.

Changelog

.buildsystem/deploy-github.sh
- Removed the GitHub deployment script.
.buildsystem/deploy-sonatype.sh
- Removed the Sonatype deployment script.
.github/git-commit-instructions.md
- Updated commit instructions to include a section on updating GitHub Workflows.
AGENTS.md
- Added a new documentation file detailing project build, architecture, dependencies, code style, and CI.
adam/build.gradle.kts
- Added build logic imports for publishing and integration tests.
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
- Replaced inline integration test source set and task configurations with dedicated build logic functions.
- Updated Dokka configuration for HTML publication.
- Replaced libs.logging with libs.logcat in dependencies.
adam/src/integrationTest/kotlin/com/malinskiy/adam/extension/File.kt
- Removed trailing newline character.
adam/src/integrationTest/kotlin/com/malinskiy/adam/extension/FileExtension.kt
- Added a trailing comma to the produce function call.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/ApkE2ETest.kt
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/E2ETest.kt
- Removed blank line.
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/EmulatorE2ETest.kt
- Added a trailing comma to the EmulatorCommandRequest constructor call.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/FileE2ETest.kt
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/LogcatE2ETest.kt
- Added a trailing comma to the Pattern.compile function call.
- Updated comments for clarity.
- Added trailing commas to function calls for improved formatting.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/ManualTest.kt
- Added a trailing comma to the AsyncDeviceMonitorRequest constructor call.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/PortForwardE2ETest.kt
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/PullE2ETest.kt
- Removed blank line.
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
- Renamed local variables for clarity (e.g., X to xDir).
- Removed trailing newline character.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/PushE2ETest.kt
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
- Renamed local variables for clarity (e.g., X to xDir).
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/ShellV2E2ETest.kt
- Added trailing commas to ShellCommandInputChunk constructor calls.
- Updated comments for clarity.
- Removed blank line.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/TestRunnerE2ETest.kt
- Added trailing commas to function calls for improved formatting.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/feature/AbbE2ETest.kt
- Added a trailing comma to the AbbRequest constructor call.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/feature/AbbExecE2ETest.kt
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/feature/CmdE2ETest.kt
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/feature/LsV2E2ETest.kt
- Added trailing commas to function calls for improved formatting.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/feature/SendRecvV2E2ETest.kt
- Added trailing commas to function calls for improved formatting.
- Updated comments for clarity.
adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/feature/StatV2E2ETest.kt
- Added trailing commas to function calls for improved formatting.
adam/src/integrationTest/kotlin/com/malinskiy/adam/rule/AdbDeviceRule.kt
- Updated comments for clarity.
- Added trailing commas to function calls for improved formatting.
adam/src/integrationTest/kotlin/com/malinskiy/adam/rule/DeviceType.kt
- Added a trailing comma to the ANY enum entry.
adam/src/main/kotlin/com/malinskiy/adam/AndroidDebugBridgeClient.kt
- Changed class and function visibility to public.
- Added trailing commas to constructor and function calls.
adam/src/main/kotlin/com/malinskiy/adam/AndroidDebugBridgeClientFactory.kt
- Changed class and property visibility to public.
- Added trailing commas to constructor calls.
adam/src/main/kotlin/com/malinskiy/adam/Const.kt
- Changed object and property visibility to public.
- Added explicit types to constants.
- Added trailing commas to byte array definitions.
adam/src/main/kotlin/com/malinskiy/adam/annotation/Features.kt
- Changed annotation visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/exception/PullFailedException.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/exception/PushFailedException.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/exception/RequestRejectedException.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/exception/RequestValidationException.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/exception/UnsupportedForwardingSpecException.kt
- Changed class visibility to public.
- Added trailing comma to constructor call.
adam/src/main/kotlin/com/malinskiy/adam/exception/UnsupportedImageProtocolException.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/exception/UnsupportedSyncProtocolException.kt
- Changed class and constructor visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/extension/ByteArray.kt
- Changed extension function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/extension/ByteBuffer.kt
- Changed extension function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/extension/Int.kt
- Changed extension function visibility to public.
- Added a trailing comma to the byte array definition.
adam/src/main/kotlin/com/malinskiy/adam/extension/List.kt
- Changed extension function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/extension/Socket.kt
- Changed extension function visibility to public.
- Added trailing commas to copyTo function parameters.
- Updated comments for clarity.
adam/src/main/kotlin/com/malinskiy/adam/interactor/AdbBinaryInteractor.kt
- Changed class and function visibility to public.
- Added a trailing comma to the execute function parameter list.
adam/src/main/kotlin/com/malinskiy/adam/interactor/DiscoverAdbSocketInteractor.kt
- Changed class and function visibility to public.
- Changed companion object visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/interactor/StartAdbInteractor.kt
- Changed class and function visibility to public.
- Added a trailing comma to the execute function parameter list.
adam/src/main/kotlin/com/malinskiy/adam/interactor/StopAdbInteractor.kt
- Changed class and function visibility to public.
- Added a trailing comma to the execute function parameter list.
adam/src/main/kotlin/com/malinskiy/adam/io/AsyncFileReader.kt
- Changed class and function visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added a blank line in when statement for readability.
adam/src/main/kotlin/com/malinskiy/adam/io/AsyncFileWriter.kt
- Changed class and function visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/log/AdamLogging.kt
- Replaced mu.KLogger and mu.KotlinLogging with logcat library.
- Introduced AdamLogger class with inline logging functions for different log priorities.
adam/src/main/kotlin/com/malinskiy/adam/request/AccumulatingMultiRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/AsyncChannelRequest.kt
- Changed class and function visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/ComplexRequest.kt
- Changed class and function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/Feature.kt
- Changed enum and function visibility to public.
- Added a trailing comma to the SENDRECV_V2_DRY_RUN_SEND enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/MultiRequest.kt
- Changed class and function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/Request.kt
- Changed class and function visibility to public.
- Changed companion object visibility to public.
- Updated comment for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/SynchronousRequest.kt
- Changed class visibility to public.
- Added a blank line in when statement for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/Target.kt
- Changed sealed class and object visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/ValidationResponse.kt
- Changed data class and companion object visibility to public.
- Added explicit return types to companion object functions.
- Added trailing commas to function parameter lists.
adam/src/main/kotlin/com/malinskiy/adam/request/abb/AbbExecRequest.kt
- Changed class and companion object visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/abb/AbbRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
adam/src/main/kotlin/com/malinskiy/adam/request/adbd/AdbdMode.kt
- Changed sealed class and object visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/adbd/RestartAdbdRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
- Added a trailing comma to the createBaseRequest function call.
adam/src/main/kotlin/com/malinskiy/adam/request/device/AsyncDeviceMonitorRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added a trailing comma to the Device constructor call.
adam/src/main/kotlin/com/malinskiy/adam/request/device/FetchDeviceFeaturesRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/device/ListDevicesRequest.kt
- Changed class, data class, and enum visibility to public.
- Added a trailing comma to the Device constructor call.
- Added a trailing comma to the UNKNOWN enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/emu/EmulatorCommandRequest.kt
- Changed class and companion object visibility to public.
- Added trailing commas to constructor and function calls.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/file/ListFilesRequest.kt
- Changed class, enum, and data class visibility to public.
- Updated regex definition for readability.
- Added a trailing comma to the AndroidFile constructor call.
adam/src/main/kotlin/com/malinskiy/adam/request/forwarding/ListPortForwardsRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added a trailing comma to the PortForwardingRule constructor call.
adam/src/main/kotlin/com/malinskiy/adam/request/forwarding/LocalPortSpec.kt
- Changed sealed class, data class, and companion object visibility to public.
- Added explicit return types to functions.
- Added a trailing comma to the LocalTcpPortSpec constructor parameter.
adam/src/main/kotlin/com/malinskiy/adam/request/forwarding/PortForwardRequest.kt
- Changed class and enum visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added a trailing comma to the NO_REBIND enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/forwarding/PortForwardingRule.kt
- Changed data class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/forwarding/RemotePortSpec.kt
- Changed sealed class, data class, and companion object visibility to public.
- Added explicit return types to functions.
adam/src/main/kotlin/com/malinskiy/adam/request/forwarding/RemoveAllPortForwardsRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
adam/src/main/kotlin/com/malinskiy/adam/request/forwarding/RemovePortForwardRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/BufferedImageScreenCaptureAdapter.kt
- Changed class visibility to public.
- Added trailing commas to constructor and function calls.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/Color.kt
- Added file-level suppressions for naming conventions.
- Changed object and function visibility to public.
- Added trailing commas to function parameter lists.
adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/ColorModelFactory.kt
- Changed class and function visibility to public.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/ColorSpace.kt
- Changed enum and companion object visibility to public.
- Added a trailing comma to the P3 enum entry.
- Added explicit return types to functions.
adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/RawImage.kt
- Changed data class and function visibility to public.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/RawImageScreenCaptureAdapter.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/ScreenCaptureAdapter.kt
- Changed abstract class and function visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/ScreenCaptureRequest.kt
- Changed class visibility to public.
- Added blank lines in when statements for readability.
- Added a trailing comma to the adapter.process function calls.
adam/src/main/kotlin/com/malinskiy/adam/request/logcat/ChanneledLogcatRequest.kt
- Changed class and enum visibility to public.
- Added @Suppress annotation for enum entry naming.
- Updated command string concatenation for readability.
- Added trailing commas to enum entries.
adam/src/main/kotlin/com/malinskiy/adam/request/logcat/LogcatSinceFormat.kt
- Changed sealed class and class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/logcat/SyncLogcatRequest.kt
- Changed class visibility to public.
- Updated command string concatenation for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/mdns/ListMdnsServicesRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the MdnsService constructor call.
adam/src/main/kotlin/com/malinskiy/adam/request/mdns/MdnsCheckRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/mdns/MdnsService.kt
- Changed data class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/mdns/MdnsStatus.kt
- Changed data class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/ConnectDeviceRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/DisconnectDeviceRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/ExecInRequest.kt
- Changed class visibility to public.
- Added trailing commas to constructor and function calls.
- Updated comments for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/FetchHostFeaturesRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/GetAdbServerVersionRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/KillAdbRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/PairDeviceRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/RebootRequest.kt
- Changed class and enum visibility to public.
- Added explicit return types to overridden functions.
- Added a trailing comma to the SIDELOAD_AUTO_REBOOT enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/ReconnectRequest.kt
- Changed class, sealed class, and object visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated comments for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/RemountPartitionsRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
- Added a trailing comma to the createBaseRequest function call.
adam/src/main/kotlin/com/malinskiy/adam/request/misc/SetDeviceRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/AtomicInstallPackageRequest.kt
- Changed class visibility to public.
- Added trailing commas to constructor and function calls.
- Updated comments for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/InstallRemotePackageRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated validation message for unsupported package extensions.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/InstallSplitPackageRequest.kt
- Changed class and companion object visibility to public.
- Added trailing commas to constructor and function calls.
- Updated comments for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/LegacySideloadRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/PmListRequest.kt
- Changed class and data class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/SideloadRequest.kt
- Changed class visibility to public.
- Updated comments for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/StreamingPackageInstallRequest.kt
- Changed class, data class, and companion object visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/UninstallRemotePackageRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/multi/AddSessionRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/multi/CreateIndividualPackageSessionRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added blank lines in when statement for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/multi/CreateMultiPackageSessionRequest.kt
- Changed class and companion object visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added blank lines in when statement for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/multi/CreateSessionResponse.kt
- Changed data class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/multi/InstallCommitRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated comments for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/multi/InstallationPackage.kt
- Changed sealed class, data class, and constructor visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/pkg/multi/WriteIndividualPackageRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added blank lines in when statement for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/prop/GetPropRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/prop/GetSinglePropRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/reverse/ListReversePortForwardsRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added a trailing comma to the ReversePortForwardingRule constructor call.
adam/src/main/kotlin/com/malinskiy/adam/request/reverse/RemoveAllReversePortForwardsRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
adam/src/main/kotlin/com/malinskiy/adam/request/reverse/RemoveReversePortForwardRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
adam/src/main/kotlin/com/malinskiy/adam/request/reverse/ReversePortForwardRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/reverse/ReversePortForwardingRule.kt
- Changed data class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/security/SetDmVerityCheckingRequest.kt
- Changed class visibility to public.
- Added explicit return types to overridden functions.
- Added a trailing comma to the createBaseRequest function call.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/AsyncCompatShellCommandRequest.kt
- Changed class and function visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v1/ChanneledShellCommandRequest.kt
- Changed class and function visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated comment for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v1/ShellCommandRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v1/ShellCommandResult.kt
- Changed data class and property visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v1/ShellResultResponseTransformer.kt
- Changed class visibility to public.
- Added explicit return type to transform function.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v1/SyncShellCommandRequest.kt
- Changed abstract class and companion object visibility to public.
- Added explicit return types to functions.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v2/ChanneledShellCommandRequest.kt
- Changed class, data class, and enum visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated comments for clarity.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v2/MessageType.kt
- Changed enum and companion object visibility to public.
- Added a trailing comma to the INVALID enum entry.
- Added explicit return types to functions.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v2/ShellCommandRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v2/ShellCommandResult.kt
- Changed data class and property visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/shell/v2/SyncShellCommandRequest.kt
- Changed abstract class visibility to public.
- Added explicit return types to functions.
- Updated comment for clarity.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/BFFSearch.kt
- Added trailing commas to lambda parameters.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/PullRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated comments and error messages for clarity.
- Added blank lines in when statements for readability.
- Added a trailing comma to the SyncFile constructor call.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/PushRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated comments and error messages for clarity.
- Added blank lines in when statements for readability.
- Added a trailing comma to the SyncFile constructor call.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/base/BasePullFileRequest.kt
- Changed abstract class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated comments for clarity.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/base/BasePushFileRequest.kt
- Changed abstract class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Updated comments for clarity.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/compat/CompatListFileRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/compat/CompatPullFileRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/compat/CompatPushFileRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/compat/CompatStatFileRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/model/FileEntry.kt
- Changed sealed class, data class, and function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/model/SyncFile.kt
- Added a trailing comma to the data class constructor.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v1/ListFileRequest.kt
- Changed class visibility to public.
- Removed blank line.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v1/PullFileRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v1/PushFileRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v1/StatFileRequest.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v2/CompressionType.kt
- Changed enum visibility to public.
- Added a trailing comma to the Zstd enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v2/ListFileRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added blank lines in when statements for readability.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v2/PullFileRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v2/PushFileRequest.kt
- Changed class and companion object visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/sync/v2/StatFileRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/InstrumentOptions.kt
- Changed data class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/InstrumentationSizeOption.kt
- Changed enum visibility to public.
- Added a trailing comma to the LARGE enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/TestEvent.kt
- Changed sealed class and data class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/TestIdentifier.kt
- Changed data class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/TestRunnerRequest.kt
- Changed class visibility to public.
- Added a trailing comma to the constructor parameter list.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/model/SessionResultCode.kt
- Changed enum visibility to public.
- Added a trailing comma to the ERROR enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/model/State.kt
- Changed sealed class and object visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/model/Status.kt
- Changed enum and companion object visibility to public.
- Added a trailing comma to the UNKNOWN enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/model/StatusKey.kt
- Changed enum and companion object visibility to public.
- Added a trailing comma to the UNKNOWN enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/model/TestStatusAggregator.kt
- Changed data class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/model/TokenType.kt
- Changed enum visibility to public.
- Added a trailing comma to the INSTRUMENTATION_FAILED enum entry.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/transform/InstrumentationResponseTransformer.kt
- Updated copyright year.
- Changed class and companion object visibility to public.
- Added blank lines in when statements for readability.
- Added trailing commas to function calls.
adam/src/main/kotlin/com/malinskiy/adam/request/testrunner/transform/ProtoInstrumentationResponseTransformer.kt
- Updated copyright year.
- Added explicit imports for various test runner classes.
- Changed class visibility to public.
- Added blank lines in when statements for readability.
- Added trailing commas to function calls.
adam/src/main/kotlin/com/malinskiy/adam/request/transform/DumpResponseTransformer.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/transform/ProgressiveResponseTransformer.kt
- Changed interface visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/transform/ResponseTransformer.kt
- Changed interface visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/request/transform/StringResponseTransformer.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/transport/BufferFactory.kt
- Changed visibility of AdamDefaultPool, AdamMaxPacketPool, AdamMaxFilePacketPool to public.
- Changed class and inline function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/transport/Socket.kt
- Changed interface and function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/transport/SocketFactory.kt
- Changed interface and function visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/transport/SuspendCloseable.kt
- Changed interface and inline function visibility to public.
- Updated comment for clarity.
adam/src/main/kotlin/com/malinskiy/adam/transport/TransportResponse.kt
- Changed class visibility to public.
adam/src/main/kotlin/com/malinskiy/adam/transport/vertx/VariableSizeRecordParser.kt
- Changed class visibility to public.
- Replaced EMPTY_BUFFER with emptyBuffer.
- Replaced Object() with Any() for bufferLock.
- Updated drained getter to use buff.length().
- Replaced Arguments.require with require for argument validation.
- Added explicit return types to overridden functions.
adam/src/main/kotlin/com/malinskiy/adam/transport/vertx/VertxSocket.kt
- Changed class and property visibility to public.
- Replaced await() with coAwait() for Vert.x coroutine calls.
- Updated readAvailable to use it.length() instead of it.byteBuf.writerIndex().
adam/src/main/kotlin/com/malinskiy/adam/transport/vertx/VertxSocketFactory.kt
- Changed class visibility to public.
- Replaced await() with coAwait() for Vert.x coroutine calls.
- Updated toTimeoutInt() logic for clarity.
adam/src/test/kotlin/com/malinskiy/adam/AndroidDebugBridgeClientTest.kt
- Added trailing commas to anonymous object definition.
adam/src/test/kotlin/com/malinskiy/adam/integration/AdbBinaryIntegrationTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/interactor/DiscoverAdbSocketInteractorTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/AsyncShellCommandRequestTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/TargetTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/abb/AbbExecRequestTest.kt
- Added trailing commas to function calls.
adam/src/test/kotlin/com/malinskiy/adam/request/device/FetchDeviceFeaturesRequestTest.kt
- Added trailing commas to byte array conversion and list of features.
adam/src/test/kotlin/com/malinskiy/adam/request/device/ListDevicesRequestTest.kt
- Added trailing commas to map and list definitions.
adam/src/test/kotlin/com/malinskiy/adam/request/forwarding/ListPortForwardsRequestTest.kt
- Added trailing commas to multiline string and list definitions.
adam/src/test/kotlin/com/malinskiy/adam/request/forwarding/LocalPortSpecTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/forwarding/PortForwardRequestTest.kt
- Added a trailing comma to the PortForwardRequest constructor call.
adam/src/test/kotlin/com/malinskiy/adam/request/forwarding/RemotePortSpecTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/forwarding/RemovePortForwardRequestTest.kt
- Added trailing commas to function calls.
adam/src/test/kotlin/com/malinskiy/adam/request/framebuffer/ScreenCaptureRequestTest.kt
- Removed unused io.ktor.utils.io.writeIntLittleEndian import.
- Removed blank line.
- Updated comment for clarity.
- Added a trailing comma to the compare function parameter list.
adam/src/test/kotlin/com/malinskiy/adam/request/framebuffer/screencapture/BufferedImageScreenCaptureAdapterTest.kt
- Added a trailing comma to the process function call.
adam/src/test/kotlin/com/malinskiy/adam/request/logcat/AsyncLogcatRequestTest.kt
- Added trailing commas to list definitions.
adam/src/test/kotlin/com/malinskiy/adam/request/mdns/ListMdnsServicesRequestTest.kt
- Added trailing commas to byte array conversion and MdnsService constructor call.
adam/src/test/kotlin/com/malinskiy/adam/request/mdns/MdnsCheckRequestTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/misc/DisconnectDeviceRequestTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/misc/FetchHostFeaturesRequestTest.kt
- Added trailing commas to list of features.
adam/src/test/kotlin/com/malinskiy/adam/request/misc/RebootRequestTest.kt
- Added a trailing comma to the RebootRequest constructor call.
adam/src/test/kotlin/com/malinskiy/adam/request/pkg/InstallRemotePackageRequestTest.kt
- Added trailing commas to function calls.
adam/src/test/kotlin/com/malinskiy/adam/request/pkg/multi/AddSessionRequestTest.kt
- Added trailing commas to function calls and multiline string.
adam/src/test/kotlin/com/malinskiy/adam/request/pkg/multi/CreateIndividualPackageSessionRequestTest.kt
- Added trailing commas to constructor calls.
adam/src/test/kotlin/com/malinskiy/adam/request/pkg/multi/CreateMultiPackageSessionRequestTest.kt
- Removed unused io.ktor.utils.io imports.
- Added trailing commas to constructor calls.
- Updated temporary file creation to use kotlin.io.path.createTempFile.
adam/src/test/kotlin/com/malinskiy/adam/request/pkg/multi/InstallCommitRequestTest.kt
- Added trailing commas to constructor calls.
adam/src/test/kotlin/com/malinskiy/adam/request/pkg/multi/WriteIndividualPackageRequestTest.kt
- Added trailing commas to constructor calls and multiline string.
adam/src/test/kotlin/com/malinskiy/adam/request/reverse/ListReversePortForwardsRequestTest.kt
- Added trailing commas to multiline string and list definitions.
adam/src/test/kotlin/com/malinskiy/adam/request/reverse/RemoveReversePortForwardRequestTest.kt
- Added trailing commas to function calls.
adam/src/test/kotlin/com/malinskiy/adam/request/reverse/ReversePortForwardRequestTest.kt
- Added trailing commas to constructor calls.
adam/src/test/kotlin/com/malinskiy/adam/request/shell/v1/ChanneledShellCommandRequestTest.kt
- Added trailing commas to function calls.
adam/src/test/kotlin/com/malinskiy/adam/request/shell/v1/ShellCommandRequestTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/shell/v1/ShellResultResponseTransformerTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/shell/v2/ChanneledShellCommandRequestTest.kt
- Added a trailing comma to the ChanneledShellCommandRequest constructor call.
adam/src/test/kotlin/com/malinskiy/adam/request/shell/v2/ShellCommandRequestTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/ListFilesRequestTest.kt
- Added trailing commas to multiline string and AndroidFile constructor calls.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/compat/CompatListFileRequestTest.kt
- Added trailing commas to FileEntryV1 and FileEntryV2 constructor calls.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/compat/CompatStatFileRequestTest.kt
- Added trailing commas to FileEntryV2 constructor calls.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v1/ListFileRequestTest.kt
- Removed blank lines.
- Added trailing commas to FileEntryV1 constructor call.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v1/PullFileRequestTest.kt
- Removed unused io.ktor.utils.io.writeIntLittleEndian import.
- Added trailing commas to function calls.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v1/PushFileRequestTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v1/StatFileRequestTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v2/ListFileRequestTest.kt
- Added trailing commas to FileEntryV2 constructor call.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v2/PullFileRequestTest.kt
- Removed unused io.ktor.utils.io.writeIntLittleEndian import.
- Added trailing commas to function calls.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v2/PushFileRequestTest.kt
- Removed blank lines.
adam/src/test/kotlin/com/malinskiy/adam/request/sync/v2/StatFileRequestTest.kt
- Removed blank lines.
- Added trailing commas to FileEntryV2 constructor call.
adam/src/test/kotlin/com/malinskiy/adam/request/testrunner/InstrumentOptionsTest.kt
- Added trailing commas to constructor calls and multiline string.
adam/src/test/kotlin/com/malinskiy/adam/request/testrunner/TestRunnerRequestTest.kt
- Added trailing commas to constructor calls and multiline strings.
adam/src/test/kotlin/com/malinskiy/adam/request/testrunner/transform/InstrumentationResponseTransformerTest.kt
- Added trailing commas to multiline strings.
- Updated string concatenation for readability.
android-junit4-test-annotation-producer/build.gradle.kts
- Added build logic imports for publishing.
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
android-junit4-test-annotation-producer/src/main/kotlin/com/malinskiy/adam/junit4/android/listener/TestAnnotationProducer.kt
- Changed class visibility to public.
- Added trailing commas to list and ArrayList constructor calls.
android-junit4/build.gradle.kts
- Added build logic imports for publishing.
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
android-junit4/src/main/kotlin/com/malinskiy/adam/junit4/android/UnsafeAdbAccess.kt
- Added a trailing comma to the message parameter of @RequiresOptIn.
- Changed annotation visibility to public.
android-junit4/src/main/kotlin/com/malinskiy/adam/junit4/android/rule/AdbRule.kt
- Added @OptIn(UnsafeAdbAccess::class) annotation to the class.
- Changed class and property visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added a trailing comma to the AssumptionViolatedException constructor call.
android-junit4/src/main/kotlin/com/malinskiy/adam/junit4/android/rule/EmulatorConsoleRule.kt
- Changed class and function visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added trailing commas to AssumptionViolatedException and AssertionError constructor calls.
android-junit4/src/main/kotlin/com/malinskiy/adam/junit4/android/rule/EmulatorGrpcRule.kt
- Changed class and property visibility to public.
- Added a trailing comma to the constructor parameter list.
- Added trailing commas to AssumptionViolatedException and AssertionError constructor calls.
android-junit4/src/main/kotlin/com/malinskiy/adam/junit4/android/rule/Mode.kt
- Changed enum visibility to public.
- Added a trailing comma to the ASSERT enum entry.
android-junit4/src/main/kotlin/com/malinskiy/adam/junit4/android/rule/sandbox/SingleTargetAndroidDebugBridgeClient.kt
- Changed class and function visibility to public.
- Added a trailing comma to the constructor parameter list.
android-testrunner-contract/build.gradle.kts
- Added build logic imports for publishing.
- Replaced id("java") with id("adam.java").
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
- Removed explicit Java source/target compatibility and Kotlin JVM target configuration.
androidx-screencapture/build.gradle.kts
- Added build logic imports for publishing.
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
androidx-screencapture/src/main/kotlin/com/malinskiy/adam/junit4/android/screencapture/AdamScreenCaptureProcessor.kt
- Added file-level suppression for deprecation.
- Changed class visibility to public.
- Added a trailing comma to the bundle.putString function call.
androidx-screencapture/src/main/kotlin/com/malinskiy/adam/junit4/android/screencapture/AdamScreenCaptureRule.kt
- Added file-level suppression for deprecation.
- Changed class visibility to public.
build.gradle.kts
- Removed gradle-versions plugin application.
- Applied vanniktech.maven.publish plugin with apply false.
- Configured project version based on RELEASE_TAG environment variable or default.
- Configured Maven publishing for all subprojects to GitHub Packages with credentials.
buildSrc/src/main/kotlin/Versions.kt
- Removed file.
buildSrc/src/main/kotlin/adam.android.library.gradle.kts
- Applied adam.code.lint plugin.
- Added explicitApi() to Kotlin configuration.
buildSrc/src/main/kotlin/adam.java.gradle.kts
- Added new Gradle plugin for Java projects, applying java and adam.code.lint plugins.
- Configured Java source and target compatibility using ProjectConfig.JavaVersion.
- Configured Kotlin JVM target using ProjectConfig.JvmTarget.
buildSrc/src/main/kotlin/adam.jvm.gradle.kts
- Applied adam.code.lint plugin.
- Added explicitApi() to Kotlin configuration.
- Configured Jacoco reports to require XML reports.
buildSrc/src/main/kotlin/adam/buildlogic/IntegrationTestConfig.kt
- Added new file for configuring integration test source sets and tasks, including Jacoco reports.
buildSrc/src/main/kotlin/adam/buildlogic/MavenPomConfig.kt
- Added new file defining AdamPublishing object and configureAdamPom extension function for Maven POM configuration.
gradle/libs.versions.toml
- Updated versions for Kotlin, Coroutines, Annotations, Ktor, Vert.x, Apache Commons Pool2, AssertK, JUnit5, gRPC, Protobuf, Android Gradle Plugin, Test Monitor, Test Runner.
- Replaced logging with logcat library.
- Removed gradleVersionsPlugin and added vanniktechMavenPublish.
server/server-stub-junit4/build.gradle.kts
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
server/server-stub-junit4/src/main/kotlin/com/malinskiy/adam/server/junit4/AdbServerRule.kt
- Changed class and property visibility to public.
server/server-stub-junit4/src/test/kotlin/com/malinskiy/adam/server/junit4/AdbServerRuleTest.kt
- Changed class and property visibility to public.
server/server-stub-junit5/build.gradle.kts
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
server/server-stub-junit5/src/main/kotlin/com/malinskiy/adam/server/junit5/AdbClient.kt
- Changed annotation visibility to public.
server/server-stub-junit5/src/main/kotlin/com/malinskiy/adam/server/junit5/AdbServer.kt
- Changed annotation visibility to public.
server/server-stub-junit5/src/main/kotlin/com/malinskiy/adam/server/junit5/AdbServerExtension.kt
- Changed class and function visibility to public.
- Updated filter condition for setupServerField and setupClientField.
- Removed nullable context parameter from afterEach.
server/server-stub-junit5/src/main/kotlin/com/malinskiy/adam/server/junit5/AdbTest.kt
- Changed annotation visibility to public.
server/server-stub-junit5/src/test/kotlin/com/malinskiy/adam/server/junit5/AdbServerExtensionTest.kt
- Changed class and property visibility to public.
server/server-stub/build.gradle.kts
- Added build logic imports for publishing and integration tests.
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
- Replaced inline integration test setup with dedicated build logic functions.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/AndroidDebugBridgeServer.kt
- Changed class and property visibility to public.
- Replaced ActorSelectorManager with SelectorManager.
- Added runBlocking for socket binding.
- Changed output.close() to output.flushAndClose().
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ConsoleReadChannel.kt
- Changed class and function visibility to public.
- Replaced readUTF8Line() with readLine().
- Added explicit readByte() and readIntLittleEndian() functions.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ConsoleWriteChannel.kt
- Changed class and function visibility to public.
- Added explicit respond function.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/EmulatorConsoleServer.kt
- Changed class and function visibility to public.
- Replaced ActorSelectorManager with SelectorManager.
- Changed output.close() to output.flushAndClose().
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ServerReadChannel.kt
- Changed class and function visibility to public.
- Added explicit readByte(), readIntLittleEndian(), readFully() functions.
- Updated receiveCommand() logic.
- Added explicit RuntimeException for unexpected protocol messages.
- Changed channel.close() to channel.flushAndClose().
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ServerWriteChannel.kt
- Changed class and function visibility to public.
- Added explicit writeIntLittleEndian(), writeLongLittleEndian(), writeFully(), writeByte() functions.
- Updated respondShellV2Exit() logic.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/StubSocket.kt
- Changed class visibility to public.
- Replaced ByteChannelSequentialJVM with ByteChannel.
- Updated readFully(), writeFully(), readAvailable(), readByte(), readIntLittleEndian(), writeByte(), writeIntLittleEndian() functions.
- Changed writeChannel.close() to writeChannel.flushAndClose().
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/DeviceExpectation.kt
- Changed data class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/DoneFailSubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/ExecSubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/Expectation.kt
- Changed class and function visibility to public.
- Updated select function logic for clarity.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/FramebufferSubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/GetAdbServerSubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/LegacySideloadSubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/OkayFailSubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/ReceiveFileSubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/SendFileSubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/SendFileV2SubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/Session.kt
- Changed class and function visibility to public.
- Updated comments for clarity.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/ShellV1SubSession.kt
- Changed class and function visibility to public.
server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/dsl/ShellV2SubSession.kt
- Changed class and function visibility to public.
transport-ktor/build.gradle.kts
- Added build logic imports for publishing.
- Applied the Vanniktech Maven Publish plugin.
- Configured Maven publishing details including group, artifact, name, description, and POM.
- Replaced libs.logging with libs.logcat.
- Added test dependencies for JUnit4, AssertK, and Coroutines.
transport-ktor/src/main/kotlin/com/malinskiy/adam/transport/ktor/KtorSocket.kt
- Changed class visibility to public.
- Added explicit ktorReadByte and ktorWriteByte aliases.
- Updated readFully(), writeFully(), readAvailable(), readByte(), readIntLittleEndian(), writeByte(), writeIntLittleEndian() implementations.
- Changed writeChannel.close() to writeChannel.flushAndClose().
transport-ktor/src/main/kotlin/com/malinskiy/adam/transport/ktor/KtorSocketFactory.kt
- Changed class visibility to public.
- Replaced ActorSelectorManager with SelectorManager.
transport-ktor/src/test/kotlin/com/malinskiy/adam/transport/ktor/KtorSocketRegressionTest.kt
- Added new test file to verify readFully and writeFully behavior with byte arrays in KtorSocket.

Ignored Files

Ignored by pattern: .github/workflows/** (7)
- .github/workflows/ci.yaml
- .github/workflows/deploy-github-release.yaml
- .github/workflows/deploy-sonatype-release.yaml
- .github/workflows/deploy-sonatype-snapshot.yaml
- .github/workflows/github-pages.yml
- .github/workflows/lint.yaml
- .github/workflows/publish.yaml

Activity

ArthurKun21 initiated the pull request to perform dependency upgrades and resolve accompanying issues, following up on issue Update Project Dependencies and Gradle Build Configurations #1.
ArthurKun21 is testing the latest adam version on a forked project, adbpad.
ArthurKun21 plans to reduce the number of integration tests to API levels 24, 34, and 35.
ArthurKun21 addressed a spotless apply problem, noting it was due to not using the proper IDE, and rolled back its enforcement.
ArthurKun21 completed explicit API changes and plans to review code later.
ArthurKun21 prioritized dokka configuration.
ArthurKun21 plans to delete Versions.kt and update libs.versions.toml to depend on text for versioning.
gemini-code-assist[bot] identified critical type mismatches in adam/src/integrationTest/kotlin/com/malinskiy/adam/integration/PortForwardE2ETest.kt related to portString requiring .toInt() conversion.
gemini-code-assist[bot] highlighted several high-priority inefficiencies in transport-ktor/src/main/kotlin/com/malinskiy/adam/transport/ktor/KtorSocket.kt regarding readFully and writeFully operations, suggesting direct ByteBuffer usage.
gemini-code-assist[bot] noted medium-priority inefficiencies in server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/ServerWriteChannel.kt and server/server-stub/src/main/kotlin/com/malinskiy/adam/server/stub/StubSocket.kt due to unnecessary byte array allocations in I/O operations.
ArthurKun21 commented on fixing comments for protocol versions, likely due to spotless/ktlint issues.
ArthurKun21 suggested changing certain classes to data objects.
ArthurKun21 suggested checking for immutability by removing var declarations.
ArthurKun21 noted a potential Dokka problem with Android.

ArthurKun21 · 2026-02-15T06:11:24Z

Going to publish to jitpack and Github packages

ArthurKun21 · 2026-02-18T02:56:38Z

other changes would be done in another PR

… versions

ArthurKun21 · 2026-02-18T03:59:57Z

Let's convert this to mkdocs/zensical in another PR

ArthurKun21 added 2 commits February 14, 2026 14:24

chore(deps): use kotlin for dokka deps

956f8c2

feat: WIP updating project

37d0482

ArthurKun21 self-assigned this Feb 14, 2026

ArthurKun21 added the enhancement New feature or request label Feb 14, 2026

ArthurKun21 marked this pull request as draft February 14, 2026 15:26

feat: use square logcat

448e8ec

gemini-code-assist bot reviewed Feb 14, 2026

View reviewed changes

ArthurKun21 added 3 commits February 14, 2026 15:37

chore(deps): remove org.jetbrains.dokka plugin from build files

8159c11

docs: add AGENTS.md with build, test, and architecture details

d7ea6fe

ci: reduce CI due to approaching storage limits

33bf5c2

ArthurKun21 added 6 commits February 14, 2026 16:40

chore: enable explicit api in adam module

0137ad9

chore: enabled explicitApi in transport-ktor and server-stub modules

3bbaf3c

chore: move the declaration of explicit api to adam.jvm plugin

17ff8c7

chore: enable explicit API in android library module

e120787

chore: update source and target compatibility to use ProjectConfig

77f12e5

chore: apply spotless

688de77

ArthurKun21 added 3 commits February 14, 2026 18:00

ci: update dokka task to generate HTML documentation

b7dcf83

fix: address code review

08cf4d8

chore: update maven publishing plugin

637d544

ArthurKun21 commented Feb 15, 2026

View reviewed changes

adam/src/main/kotlin/com/malinskiy/adam/request/framebuffer/ScreenCaptureRequest.kt Outdated Show resolved Hide resolved

ArthurKun21 commented Feb 15, 2026

View reviewed changes

ArthurKun21 added 8 commits February 15, 2026 05:00

ci: add concurrency settings for CI jobs

c5813ad

ci: remove codecov actions from CI workflow

7aa5bf1

ci: refactor test result archiving command for clarity

5661783

docs: update AGENTS.md with build and test instructions

01a0110

ci: update concurrency settings to include dev branch

37065d4

refactor: move java plugin configuration to separate file

3d2acec

chore(deps): remove adam version from libs.versions.toml

404e0d3

chore(deps): remove Versions.kt file for environment variable handling

c524a87

docs: update AGENTS.md with improved test instructions and formatting

78a6a5b

ArthurKun21 marked this pull request as ready for review February 18, 2026 02:56

ArthurKun21 added 9 commits February 18, 2026 11:06

docs: update comments in ScreenCaptureRequest for clarity on protocol…

357eab7

… versions

ci: update pull request paths-ignore for improved workflow efficiency

9571788

chore: update CODEOWNERS to assign ownership to @ArthurKun21

d2d4370

docs: update README to improve structure and add missing links

fabc7ad

ci: update GitHub Actions workflow for improved Java setup

c543858

ci: update GitHub Actions workflow for documentation deployment

d08388e

ci: update GitHub Actions workflow to trigger on dev branch

742cc7b

ci: add pull request trigger to GitHub Actions workflow

2c68276

ci: update GitHub Actions workflow for GitHub Pages deployment

43080cc

ArthurKun21 had a problem deploying to github-pages February 18, 2026 03:45 — with GitHub Actions Failure

ArthurKun21 added 3 commits February 18, 2026 11:45

ci: remove environment configuration from GitHub Pages workflow

f9dd299

ci: rename workflow from 'Build and deploy docs' to 'Docs'

d1e9ee8

ci: update GitHub Actions workflow to trigger on master branch

5836678

ArthurKun21 merged commit 42c22d3 into dev Feb 18, 2026
9 checks passed

ArthurKun21 deleted the chore/update-dependencies branch February 18, 2026 04:12

Conversation

ArthurKun21 commented Feb 14, 2026

Uh oh!

gemini-code-assist bot commented Feb 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

ArthurKun21 commented Feb 14, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ArthurKun21 commented Feb 14, 2026

Uh oh!

ArthurKun21 commented Feb 14, 2026

Uh oh!

ArthurKun21 commented Feb 14, 2026

Uh oh!

ArthurKun21 commented Feb 14, 2026

Uh oh!

Uh oh!

ArthurKun21 Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

ArthurKun21 Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

ArthurKun21 Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

ArthurKun21 Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

ArthurKun21 Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

ArthurKun21 commented Feb 15, 2026

Uh oh!

gemini-code-assist bot commented Feb 15, 2026

Summary of Changes

Highlights

Uh oh!

ArthurKun21 commented Feb 15, 2026

Uh oh!

ArthurKun21 commented Feb 18, 2026

Uh oh!

ArthurKun21 commented Feb 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant